Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove downloadable Quarkus/Qute support in Java projects #974

Merged

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Jun 26, 2023

@fbricon fbricon added this to the 1.21.0 milestone Jun 26, 2023
@fbricon fbricon added enhancement New feature or request wizard labels Jun 26, 2023
@fbricon fbricon force-pushed the remove-downloadable-frameworks branch from 36b7f0c to 82d11a6 Compare June 26, 2023 11:59
@sonarcloud
Copy link

sonarcloud bot commented Jun 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fbricon fbricon requested a review from jeffmaury June 26, 2023 12:00
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the facet still useful ? Any reason to keep it ?

@fbricon
Copy link
Contributor Author

fbricon commented Jun 26, 2023

The facet is used to check whether a file belongs to a quarkus project

@adietish adietish requested a review from jeffmaury June 26, 2023 14:39
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbricon fbricon merged commit 70cfefe into redhat-developer:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment